Re: Run pgindent now?

From: Andres Freund <andres(at)anarazel(dot)de>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Run pgindent now?
Date: 2015-05-25 17:13:35
Message-ID: 20150525171335.GJ32396@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015-05-20 11:47:15 -0400, Robert Haas wrote:
> On Tue, May 19, 2015 at 10:26 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > To do it before every minor release would require re-indenting HEAD
> > as well (since the whole point is to keep HEAD and the back branches
> > consistent). I think we'd get too much push-back from developers
> > whose pending patches got broken. We can get away with reindenting
> > HEAD between development cycles, but probably not more often than that.
>
> I'm not convinced of that. If we did it more often, it might actually
> be less disruptive.

I personally would be fine with doing it more often. I do think that
that'd require that a) make indent is provided *and* works in VPATH
builds, b) pg_bsd_indent would have to be in src/tools.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2015-05-25 17:15:56 Re: Run pgindent now?
Previous Message Tom Lane 2015-05-25 17:10:04 Re: Run pgindent now?