Re: Fix misaligned access of ItemPointerData on ARM

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Fix misaligned access of ItemPointerData on ARM
Date: 2015-05-21 20:53:38
Message-ID: 20150521205338.GC2028@alap3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2015-05-21 16:49:27 -0400, Tom Lane wrote:
> I considered also adding a Static_assert about sizeof(ItemIdData),
> but I'm afraid that compilers that don't support these pragmas
> probably don't support Static_assert either, so it's not clear
> that that would catch anything.

I think your fallback for static assert should pretty much always work?
With an ugly message, but work nonetheless?

Andres

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-05-21 21:02:13 Re: GiST KNN Crasher
Previous Message Piotr Gasidło 2015-05-21 20:52:30 Strange replication problem - segment restored from archive but still requested from master