| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Piotr Stefaniak <postgres(at)piotr-stefaniak(dot)me>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fix misaligned access of ItemPointerData on ARM |
| Date: | 2015-05-21 21:22:57 |
| Message-ID: | 14761.1432243377@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2015-05-21 16:49:27 -0400, Tom Lane wrote:
>> I considered also adding a Static_assert about sizeof(ItemIdData),
>> but I'm afraid that compilers that don't support these pragmas
>> probably don't support Static_assert either, so it's not clear
>> that that would catch anything.
> I think your fallback for static assert should pretty much always work?
> With an ugly message, but work nonetheless?
Good point. Committed with a static assertion. We shall now retire
to a safe distance and watch the buildfarm.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-05-21 21:24:00 | Re: GiST KNN Crasher |
| Previous Message | Tom Lane | 2015-05-21 21:12:29 | Re: Fix misaligned access of ItemPointerData on ARM |