Re: Typo patch

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: hlinnaka(at)iki(dot)fi, CharSyam <charsyam(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Typo patch
Date: 2015-05-20 17:37:47
Message-ID: 20150520173747.GA5885@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> > Thanks, committed. Except for this one:
>
> > - * *Only* a frozen-for-read tape can be seeked.
> > + * *Only* a frozen-for-read tape can be sought.
>
> > It's true that the past tense of "seek" is "sought", but it feels a bit
> > weird to me in this context. This is a comment on a function called
> > "<blah blah>seek", and it's not clear to me that it should conjugate
> > like the normal "seek" verb.
>
> I agree that "sought" is not the word to use here, but the existing
> wording isn't very good English either. Perhaps "Seeking is only allowed
> on frozen-for-read tapes"?

It would be great if you could find a solution for words such as
"shutdowned" or "backuped". (I don't know that we use the latter in our
code, but I've seen it around. The former we even have in an enum
somewhere.)

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-05-20 17:55:00 Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0
Previous Message Andres Freund 2015-05-20 17:37:06 Re: INSERT ... ON CONFLICT UPDATE/IGNORE 4.0