| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Recursively fsync() the data directory after a crash. |
| Date: | 2015-05-18 16:22:01 |
| Message-ID: | 20150518162201.GF9458@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On Mon, May 18, 2015 at 12:15:03PM -0400, Tom Lane wrote:
> Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> > On Mon, May 18, 2015 at 11:04 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> Huh? All the ones that are reporting kernel call failures certainly
> >> have %m.
>
> > Oops, you're right. I was looking at the wrong code. Yeah, that
> > should probably be fixed. I'm not sure it's a good idea to do that
> > right now though.
>
> It's a trivial enough change that I wouldn't see a problem with doing it
> now. But if you do, please get it in by say 2PM EDT.
Uh, doesn't that change the translated strings? Is that a problem?
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-05-18 16:39:13 | Re: pgsql: Recursively fsync() the data directory after a crash. |
| Previous Message | Tom Lane | 2015-05-18 16:15:03 | Re: pgsql: Recursively fsync() the data directory after a crash. |