| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: pg_upgrade: quote directory names in delete_old_cluster script |
| Date: | 2015-05-11 16:58:22 |
| Message-ID: | 20150511165822.GF8123@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Apr 29, 2015 at 10:52:45PM -0400, Bruce Momjian wrote:
> On Mon, Feb 16, 2015 at 05:03:45PM -0500, Bruce Momjian wrote:
> > > All of our makefiles use single quotes, so effectively the only
> > > character we don't support in directory paths is the single quote itself.
> >
> > This seems to say that Windows batch files don't have any special
> > meaning for single quotes:
> >
> > http://stackoverflow.com/questions/24173825/what-does-single-quote-do-in-windows-batch-files
> > http://stackoverflow.com/questions/10737283/single-quotes-and-double-quotes-how-to-have-the-same-behaviour-in-unix-and-wind
> >
> > Again, is it worth doing something platform-specific? I can certainly
> > define a platform-specific macro for " or ' as and use that. Good idea?
>
> I have developed the attached patch to use platform-specific quoting of
> path names.
Applied.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Geoghegan | 2015-05-11 18:41:20 | Re: pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE. |
| Previous Message | Bruce Momjian | 2015-05-11 16:57:56 | pgsql: pg_upgrade: use single or double-quotes in command-line strings |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-05-11 17:15:47 | Re: a fast bloat measurement tool (was Re: Measuring relation free space) |
| Previous Message | Robert Haas | 2015-05-11 16:54:37 | Re: multixacts woes |