| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: pg_upgrade: quote directory names in delete_old_cluster script |
| Date: | 2015-04-30 02:52:45 |
| Message-ID: | 20150430025245.GA24354@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, Feb 16, 2015 at 05:03:45PM -0500, Bruce Momjian wrote:
> > All of our makefiles use single quotes, so effectively the only
> > character we don't support in directory paths is the single quote itself.
>
> This seems to say that Windows batch files don't have any special
> meaning for single quotes:
>
> http://stackoverflow.com/questions/24173825/what-does-single-quote-do-in-windows-batch-files
> http://stackoverflow.com/questions/10737283/single-quotes-and-double-quotes-how-to-have-the-same-behaviour-in-unix-and-wind
>
> Again, is it worth doing something platform-specific? I can certainly
> define a platform-specific macro for " or ' as and use that. Good idea?
I have developed the attached patch to use platform-specific quoting of
path names.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| Attachment | Content-Type | Size |
|---|---|---|
| upgrade_quote.diff | text/x-diff | 3.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-04-30 02:59:26 | Re: pg_upgrade: quote directory names in delete_old_cluster script |
| Previous Message | Alvaro Herrera | 2015-04-30 02:22:35 | Re: pgsql: Correct replication origin's use of UINT16_MAX to PG_UINT16_MAX. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2015-04-30 02:59:26 | Re: pg_upgrade: quote directory names in delete_old_cluster script |
| Previous Message | Tomas Vondra | 2015-04-30 01:12:10 | Re: alternative compression algorithms? |