Re: pgsql: psql: fix \connect with URIs and conninfo strings

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers <pgsql-committers(at)postgresql(dot)org>
Subject: Re: pgsql: psql: fix \connect with URIs and conninfo strings
Date: 2015-04-02 14:57:33
Message-ID: 20150402145733.GC941@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

eOn Thu, Apr 2, 2015 at 10:41:55AM -0400, Robert Haas wrote:
> On Thu, Apr 2, 2015 at 10:38 AM, Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> > On Thu, Apr 2, 2015 at 10:19:51AM -0400, Robert Haas wrote:
> >> On Thu, Apr 2, 2015 at 10:09 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> >> >> On Thu, Apr 2, 2015 at 10:00 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> >> >>> I'm going to revert that commit in HEAD shortly, unless Alvaro pops
> >> >>> up and promises a fix PDQ. Or you could do the same.
> >> >
> >> >> I was thinking of changing master to look like the 9.4 version.
> >> >
> >> > [ shrug... ] IMO, a quick "git revert" is less work and leaves a cleaner
> >> > state for Alvaro to apply whatever final solution he settles on.
> >> > But do what you wish.
> >>
> >> OK, I've just reverted it.
> >
> > Can I ask about the logic of why this bug fix was backpatched, or is
> > that clear to everyone but me.
>
> What is your question, exactly? There was a fair amount of discussion
> of whether and how to back-patch this on pgsql-hackers.

Uh, I didn't see a huge amount of discussion, but I guess it is
sufficient:

http://www.postgresql.org/message-id/flat/20150109191551(dot)GA32660(at)fetter(dot)org#20150109191551(dot)GA32660@fetter.org

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2015-04-02 15:06:59 Re: pgsql: psql: fix \connect with URIs and conninfo strings
Previous Message Robert Haas 2015-04-02 14:43:57 pgsql: Fix another bug in DSM_CREATE_NULL_IF_MAXSEGMENTS handling.