| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: Zero-padding and zero-masking fixes for to_char(float) |
| Date: | 2015-03-22 01:46:24 |
| Message-ID: | 20150322014624.GD10795@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Mar 18, 2015 at 05:52:44PM -0400, Bruce Momjian wrote:
> In September, while researching the to_char() buffer overflow bugs fixed
> in 9.4.1 (commit 0150ab567bcf5e5913e2b62a1678f84cc272441f), I found an
> inconsistency in how to_char() does zero-padding for float4/8 values.
> Now that 9.4.1 is released and I am home for a while, I am ready to
> address this.
...
> float4/8 are padding to the internal precision, while int4/numeric are
> padding based on the requested precision. This is inconsistent.
>
> The first attached patch fixes this, and also zeros the "junk" digits
> which exceed the precision of the underlying type:
Patch applied.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2015-03-22 01:46:55 | Re: PATCH: numeric timestamp in log_line_prefix |
| Previous Message | Tomas Vondra | 2015-03-22 01:41:44 | Re: PATCH: numeric timestamp in log_line_prefix |