Re: Possible typo in create_policy.sgml

* Robert Haas (robertmhaas(at)gmail(dot)com) wrote:
> On Tue, Jan 6, 2015 at 4:07 PM, Peter Geoghegan <pg(at)heroku(dot)com> wrote:
> > On Tue, Jan 6, 2015 at 1:03 PM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
> >> I thought my rewrite clarified this distinction pretty well. Maybe
> >> I'm wrong? We're talking about the same paragraph.
> >
> > Sorry, I didn't express myself clearly. I think that you did get it
> > right, but I would like to see that distinction also reflected in the
> > actual sgml PARAMETER class tag. "expression" is way too generic here.
>
> I'm happy to see us change that if it makes sense, but I'm not sure
> what that actually does.

If I'm following correctly, Peter's specifically talking about:

[ USING ( <replaceable class="parameter">expression</replaceable> ) ]
[ WITH CHECK ( <replaceable class="parameter">check_expression</replaceable> ) ]

Where the USING parameter is 'expression' but the WITH CHECK parameter
is 'check_expression'. He makes a good point, I believe, as
"expression" is overly generic. I don't like the idea of using
"barrier_expression" though as that ends up introducing a new term- how
about "using_expression"?

This would need to be reflected below in the documentation which talks
about "expression" as the parameter to "USING", but I can certainly
handle cleaning that up.

Thanks!

Stephen