Re: Proposal : REINDEX SCHEMA

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Sawada Masahiko <sawada(dot)mshk(at)gmail(dot)com>
Cc: Fabrízio Mello <fabriziomello(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Proposal : REINDEX SCHEMA
Date: 2014-10-22 23:21:21
Message-ID: 20141022232121.GF1791@alvin.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Sawada Masahiko wrote:

> Thank you for reviewing.
> I agree 2) - 5).
> Attached patch is latest version patch I modified above.
> Also, I noticed I had forgotten to add the patch regarding document of
> reindexdb.

Please don't use pg_catalog in the regression test. That way we will
need to update the expected file whenever a new catalog is added, which
seems pointless. Maybe create a schema with a couple of tables
specifically for this, instead.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2014-10-23 00:30:12 Re: pg_background (and more parallelism infrastructure patches)
Previous Message Alvaro Herrera 2014-10-22 23:18:34 Re: superuser() shortcuts