Re: Shapes on the regression test for polygon

On Wed, Jul 23, 2014 at 06:12:59PM -0400, Robert Haas wrote:
> On Wed, Jul 23, 2014 at 4:06 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> >> On Mon, Jul 21, 2014 at 10:52 AM, Emre Hasegeli <emre(at)hasegeli(dot)com> wrote:
> >>> The first two shapes on src/test/regress/sql/polygon.sql do not make
> >>> sense to me.
> >
> >> Well, I think the number of tabs that makes them look best depends on
> >> your tab-stop setting. At present, I find that with 8-space tabs
> >> things seem to line up pretty well, whereas with your patch, 4-space
> >> tabs line up well.
> >
> > Perhaps we should expand tabs to spaces in those ascii-art diagrams?
> >
> >> Personally, though, my vote would be to just leave it the way it is.
> >> I don't think there's really a problem here in need of solving.
> >
> > I concur with doubting that changing the actual regression test cases
> > is a good thing to do, at least not without more analysis. But "the
> > pictures make no sense with the wrong tab setting" is a pretty simple
> > issue, and one that I can see biting people.
>
> AFAICT, the pictures make no sense with the right tab setting, either.
> The possibility that someone might use the wrong tab setting is just
> icing on the cake.

I extracted Emre's diagram adjustments from the patch and applied it,
and no tabs now. Emre, I assume your regression changes did not affect
the diagram contents.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +