Re: pgsql: Refactor replication connection code of various pg_basebackup ut

On 2014-10-05 09:49:31 -0400, Stephen Frost wrote:
> All,
>
> * Andres Freund (andres(at)anarazel(dot)de) wrote:
> > Refactor replication connection code of various pg_basebackup utilities.
> >
> > Move some more code to manage replication connection command to
> > streamutil.c. A later patch will introduce replication slot via
> > pg_receivexlog and this avoid duplicating relevant code between
> > pg_receivexlog and pg_recvlogical.
>
> Coverity is complaining that the new Create/DropReplicatSlot functions
> leak, which is technically correct (though the cases where that happens
> end up being more-or-les immediate-exit cases anyway). In any case,
> here's a patch to clean up things prior to return.

I can't get very excited about this - but I also have no problems fixing
it. I'm fine with you committing what you have. Or would you rather have
me do it?

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services