Re: pgsql: Refactor replication connection code of various pg_basebackup ut

All,

* Andres Freund (andres(at)anarazel(dot)de) wrote:
> Refactor replication connection code of various pg_basebackup utilities.
>
> Move some more code to manage replication connection command to
> streamutil.c. A later patch will introduce replication slot via
> pg_receivexlog and this avoid duplicating relevant code between
> pg_receivexlog and pg_recvlogical.

Coverity is complaining that the new Create/DropReplicatSlot functions
leak, which is technically correct (though the cases where that happens
end up being more-or-les immediate-exit cases anyway). In any case,
here's a patch to clean up things prior to return.

Thanks,

Stephen