From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Dave Page <dave(dot)page(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, CM Team <cm(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, bernd(dot)helmle(at)credativ(dot)de |
Subject: | Re: test_shm_mq failing on anole (was: Sending out a request for more buildfarm animals?) |
Date: | 2014-09-29 20:20:18 |
Message-ID: | 20140929202018.GE2084@awork2.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2014-09-29 16:16:24 -0400, Robert Haas wrote:
>
> > If you can manually run stuff on that machine, it'd be rather helpful if
> > you could put a PG_SETMASK(&BlockSig);...PG_SETMASK(&UnBlockSig); in the
> > HaveCrashedWorker() loop.
>
> I'd do it the other way around, and adjust ServerLoop to put the
> PG_SETMASK calls right around pg_usleep() and select().
Sounds good.
> But why futz with anole?
Shorter feedback cycles. Anole doesn't seem to run very often, and it
takes you to log to see whether it's just slow or hanging...
> Let's just check in the fix. It'll either fix anole or not, but we
> should fix the bug you found either way.
Right. Are you going to do it? I can, but it'll be tomorrow. I'm neck
deep in another bug right now.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2014-09-29 20:21:20 | Re: test_shm_mq failing on anole (was: Sending out a request for more buildfarm animals?) |
Previous Message | Tom Lane | 2014-09-29 20:19:50 | Re: test_shm_mq failing on anole (was: Sending out a request for more buildfarm animals?) |