| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, Dave Page <dave(dot)page(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, CM Team <cm(at)enterprisedb(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, bernd(dot)helmle(at)credativ(dot)de |
| Subject: | Re: test_shm_mq failing on anole (was: Sending out a request for more buildfarm animals?) |
| Date: | 2014-09-29 20:19:50 |
| Message-ID: | 10683.1412021990@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Mon, Sep 29, 2014 at 3:37 PM, Andres Freund <andres(at)2ndquadrant(dot)com> wrote:
>> Ah. DetermineSleepTime(), which is called while signals are unblocked!,
>> modifies BackgroundWorkerList. Previously that only iterated the list,
>> without modifying it. That's already of quite debatable safety, but
>> modifying it without having blocked signals is most definitely
>> broken. The modification was introduced by 7f7485a0c...
> Ouch. OK, yeah, that's a bug.
Yeah. Can we just postpone the signal unblock till after that function?
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-09-29 20:20:18 | Re: test_shm_mq failing on anole (was: Sending out a request for more buildfarm animals?) |
| Previous Message | Tom Lane | 2014-09-29 20:16:38 | Re: open items for 9.4 |