Re: pgsql: Add #define INT64_MODIFIER for the printf length modifier for 64

From: Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>
To: Andres Freund <andres(at)2ndquadrant(dot)com>
Cc: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>, pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Add #define INT64_MODIFIER for the printf length modifier for 64
Date: 2014-09-19 10:50:49
Message-ID: 20140919105049.GA25728@toroid.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

At 2014-09-17 17:59:19 +0200, andres(at)2ndquadrant(dot)com wrote:
>
> Abhijit: I'll later push a fix for PGAC_FUNC_SNPRINTF_SIZE_T_SUPPORT,
> but it'd good if you could check whether a configure before/after this
> commit changes other uintended things.

I just ran configure on a clean tree before and after Heikki's commit
(#ce4860) and diff'ed the results. The problem you fixed is the only
problem I see on my Linux machine. Also the only other instances of
INT64_FORMAT in config/ are now in the test itself, i.e. safe.

-- Abhijit

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2014-09-19 14:49:28 pgsql: Avoid 'clobbered by longjmp' warning in psql/copy.c.
Previous Message Andres Freund 2014-09-18 08:05:15 pgsql: Fix configure check for %z printf support after INT64_MODIFIER c