| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
| Cc: | pgsql-committers(at)postgresql(dot)org |
| Subject: | Re: pgsql: Add #define INT64_MODIFIER for the printf length modifier for 64 |
| Date: | 2014-09-17 15:59:19 |
| Message-ID: | 20140917155919.GD25775@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Hi,
On 2014-08-21 06:57:20 +0000, Heikki Linnakangas wrote:
> Add #define INT64_MODIFIER for the printf length modifier for 64-bit ints.
>
> We have had INT64_FORMAT and UINT64_FORMAT for a long time, but that's not
> good enough if you want something more exotic, like "%20lld".
>
> Abhijit Menon-Sen, per Andres Freund's suggestion.
Unfortunately this patch broke at least
PGAC_FUNC_SNPRINTF_SIZE_T_SUPPORT because that uses UINT64_FORMAT.
I only noticed because I noticed pg_vsnprintf()s in the profile. Which I
didn't use to see ;)
Abhijit: I'll later push a fix for PGAC_FUNC_SNPRINTF_SIZE_T_SUPPORT,
but it'd good if you could check whether a configure before/after this
commit changes other uintended things.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2014-09-18 08:05:15 | pgsql: Fix configure check for %z printf support after INT64_MODIFIER c |
| Previous Message | Peter Eisentraut | 2014-09-17 05:08:48 | pgsql: Fix TAP checks when current directory name contains spaces |