| From: | Tatsuo Ishii <ishii(at)postgresql(dot)org> |
|---|---|
| To: | tgl(at)sss(dot)pgh(dot)pa(dot)us |
| Cc: | andres(at)2ndquadrant(dot)com, michael(dot)paquier(at)gmail(dot)com, masao(dot)fujii(at)gmail(dot)com, harukat(at)sraoss(dot)co(dot)jp, pgsql-bugs(at)postgresql(dot)org |
| Subject: | Re: BUG #11335: an invalid prepare statement causes crash at log_statement = 'mod' or 'ddl'. |
| Date: | 2014-09-18 00:29:13 |
| Message-ID: | 20140918.092913.190358543610096443.t-ishii@sraoss.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
>> I have a hard time believing this. Are we really believing that there's
>> a significant number of clients preparing whitespace?
>
> I don't know about "significant number", but the case is specifically
> called out as legal in the FE/BE protocol spec, for example here:
>
> Therefore, an Execute phase is always terminated by the appearance of
> exactly one of these messages: CommandComplete, EmptyQueryResponse
> (if the portal was created from an empty query string), ErrorResponse,
> or PortalSuspended.
>
> If we change it, that's a protocol break, and I don't think that being a
> tad cleaner is sufficient argument for that.
Agreed. Thinking about that the simple protocol allows to use an empty
query string, there's no reason to not allow it for the extended protocol.
Best regards,
--
Tatsuo Ishii
SRA OSS, Inc. Japan
English: http://www.sraoss.co.jp/index_en.php
Japanese:http://www.sraoss.co.jp
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexey Klyukin | 2014-09-18 06:46:04 | Re: BUG #11444: autovacuum stuck for 5 days and waits on a lock |
| Previous Message | Tom Lane | 2014-09-18 00:10:52 | Re: BUG #11335: an invalid prepare statement causes crash at log_statement = 'mod' or 'ddl'. |