From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
Cc: | Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Add new psql help topics, accessible to both --help and \?. |
Date: | 2014-09-10 13:49:37 |
Message-ID: | 20140910134937.GC4701@eldon.alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Michael Paquier wrote:
> On Wed, Sep 10, 2014 at 10:04 AM, Andres Freund <andres(at)anarazel(dot)de> wrote:
> > The best plan after that seems to be to add optional_argument support to
> > getopt_long.c - looks easy enough. Do we need a configure test for
> > optional_argument? I don't think so, but I could see somebody arguing
> > the other way round.
> Adding support for optional_argument in src/port would be the best
> solution for long-term purposes. So +1 for it or we'll be limited in
> the future as well. Here is for example attached a proof-of-concept
> patch that it is not that complicated to add support for optional
> arguments... Interestingly, the current implementation dates of 2003
> in 939a59f and has not been majorly touched since. The patch has been
> tested with MSVC.
Hmm, IIRC (didn't check) we only use our getopt_long if the platform
doesn't have one. But what if the platform has one and it doesn't
support optional_argument? I think we'd need additional configure black
magic to ensure that our version is chosen in these cases.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2014-09-10 13:55:07 | Re: pgsql: Add new psql help topics, accessible to both --help and \?. |
Previous Message | Pavel Stehule | 2014-09-10 11:36:56 | Re: pgsql: Add new psql help topics, accessible to both --help and \?. |