| From: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Cc: | Peter Geoghegan <pg(at)heroku(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Josh Berkus <josh(at)agliodbs(dot)com>, Ian Barwick <ian(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andres Freund <andres(at)2ndquadrant(dot)com>, Greg Stark <stark(at)mit(dot)edu>, Jim Nasby <jim(at)nasby(dot)net>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at> |
| Subject: | Re: Doing better at HINTing an appropriate column within errorMissingColumn() |
| Date: | 2014-07-04 15:46:46 |
| Message-ID: | 20140704154646.GA8987@toroid.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At 2014-07-02 15:51:08 -0700, pg(at)heroku(dot)com wrote:
>
> Attached revision factors in everyone's concerns here, I think.
Is anyone planning to review Peter's revised patch?
> These new measures make the coding somewhat more complex than that of
> the initial version, although overall the parser code added by this
> patch is almost entirely confined to code paths concerned only with
> producing diagnostic messages to help users.
Yes, the new patch looks quite a bit more involved than earlier, but if
that's what it takes to provide a useful HINT, I guess it's not too bad.
-- Abhijit
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Abhijit Menon-Sen | 2014-07-04 16:05:11 | Re: [REVIEW] Re: Compression of full-page-writes |
| Previous Message | Stephen Frost | 2014-07-04 15:45:12 | Re: RLS Design |