From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: pgindent run for 9.4 |
Date: | 2014-05-06 19:40:52 |
Message-ID: | 20140506194051.GF30817@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Tue, May 6, 2014 at 12:38:41PM -0700, Kevin Grittner wrote:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > Kevin Grittner <kgrittn(at)ymail(dot)com> writes:
> >
> >> Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> >>> pgindent run for 9.4
> >
> >> The 13 tests above are broken by this commit. Probably the
> >> directory should be excluded from pgindent processing.
> >
> > What's broken? The buildfarm isn't complaining, and "make installcheck"
> > in src/interfaces/ecpg/test passes for me.
>
> On "make check-world" I get the attached. After the period, the
> trailing tabs in the comment have been changed to spaces in
> "expected", but are still tabs in "results".
Yes, I had to modify those lines before I pushed the pgindent changes so
'make installcheck-world' would pass. It passes here for me now. Did
you do 'make maintainer-clean' before running the tests? That might
help.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2014-05-06 19:46:06 | Re: [COMMITTERS] pgsql: pgindent run for 9.4 |
Previous Message | Kevin Grittner | 2014-05-06 19:38:41 | Re: [COMMITTERS] pgsql: pgindent run for 9.4 |
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Janes | 2014-05-06 19:41:29 | Re: proposal: Set effective_cache_size to greater of .conf value, shared_buffers |
Previous Message | Kevin Grittner | 2014-05-06 19:38:41 | Re: [COMMITTERS] pgsql: pgindent run for 9.4 |