From: | Kevin Grittner <kgrittn(at)ymail(dot)com> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: pgindent run for 9.4 |
Date: | 2014-05-06 19:46:06 |
Message-ID: | 1399405566.41569.YahooMailNeo@web122305.mail.ne1.yahoo.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> wrote:
> On Tue, May 6, 2014 at 12:38:41PM -0700, Kevin Grittner wrote:
>> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Kevin Grittner <kgrittn(at)ymail(dot)com> writes:
>>>
>>>> Bruce Momjian <bruce(at)momjian(dot)us> wrote:
>>>>> pgindent run for 9.4
>>>
>>>> The 13 tests above are broken by this commit. Probably the
>>>> directory should be excluded from pgindent processing.
>>>
>>> What's broken? The buildfarm isn't complaining, and "make installcheck"
>>> in src/interfaces/ecpg/test passes for me.
>>
>> On "make check-world" I get the attached. After the period, the
>> trailing tabs in the comment have been changed to spaces in
>> "expected", but are still tabs in "results".
>
> Yes, I had to modify those lines before I pushed the pgindent changes so
> 'make installcheck-world' would pass. It passes here for me now. Did
> you do 'make maintainer-clean' before running the tests? That might
> help.
It occurred to me after my last post that I had just done a "make
world" without any cleanup when I pulled that, and had started a
full build from "make maintainer-clean" when you sent that. :-)
I'll let you know either way when I get results from that.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
From | Date | Subject | |
---|---|---|---|
Next Message | Kevin Grittner | 2014-05-06 19:52:43 | Re: [COMMITTERS] pgsql: pgindent run for 9.4 |
Previous Message | Bruce Momjian | 2014-05-06 19:40:52 | Re: [COMMITTERS] pgsql: pgindent run for 9.4 |
From | Date | Subject | |
---|---|---|---|
Next Message | Andres Freund | 2014-05-06 19:48:04 | Re: Wanted: jsonb on-disk representation documentation |
Previous Message | Tom Lane | 2014-05-06 19:44:35 | Re: pg_shmem_allocations view |