Re: quiet inline configure check misses a step for clang

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: quiet inline configure check misses a step for clang
Date: 2014-05-01 14:12:56
Message-ID: 20140501141256.GC14243@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2014-05-01 10:10:46 -0400, Tom Lane wrote:
> Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > I still think we really need to fix this. I have three possible
> > solutions:
>
> > a) Add an external file (in the source tree) that's included in the
> > configure test.
> > b) Have a compiler specific override and specify USE_INLINE there.
> > c) Drop the requirement of quiet inlines.
>
> > a) would probably the best, but I haven't yet found a non ugly solution :(
>
> Why is (a) so hard again?
>
> (If you're wondering where to put the file, I'd vote for the config/
> directory.)

If we accept that the test includes a external file that's included in
the source tree, it's not hard. What'd be hard is to generate a second
file via autoconf. I looked at doing the latter and it seemed far to
complex.

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Thomas Reiss 2014-05-01 14:42:09 Re: Small doc patch for pg_replication_slots
Previous Message Tom Lane 2014-05-01 14:10:46 Re: quiet inline configure check misses a step for clang