Re: Re: [COMMITTERS] pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-(

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Re: [COMMITTERS] pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-(
Date: 2014-04-28 15:32:15
Message-ID: 20140428153215.GI25695@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Tom Lane wrote:

> What might be less breakable is to identify exactly which declarations
> pg_controldata needs out of this file and push just those into some new
> header.

Yeah, I also thought about that but didn't get around to trying.

> However, pg_controldata is just the tip of the iceberg --- to get any
> mileage out of this, we'd also have to make pg_resetxlog and pg_xlogdump
> able to compile with only postgres_fe.h, so there might be too much stuff
> involved.

IIRC we didn't have pg_xlogdump when I wrote this, and I checked
pg_resetxlog and it wasn't nearly as simple as pg_controldata.

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Greg Stark 2014-04-28 17:50:34 pgsql: Add support for wrapping to psql's "extended" mode. This makes i
Previous Message Tom Lane 2014-04-28 15:19:46 Re: Re: [COMMITTERS] pgsql: Can't completely get rid of #ifndef FRONTEND in palloc.h :-(

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-04-28 15:33:21 Re: Decrease MAX_BACKENDS to 2^16
Previous Message Tom Lane 2014-04-28 15:29:14 Re: includedir_internal headers are not self-contained