Re: includedir_internal headers are not self-contained

Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> On 04/28/2014 04:51 PM, Tom Lane wrote:
>> I'm not even worried about which headers this program uses. What I'm
>> worried about is that you've got CATALOG_VERSION_NO compiled into a
>> non-server executable. Is that really such a great idea? Wouldn't it be
>> better if pg_rewind did not depend on that? (Perhaps it should get the
>> database's catalog version out of the pg_control file, for example.)

> Sure, that would be better. Although I don't have much hope to make it
> completely version-independent. At the moment, pg_rewind explicitly
> reads the control file (yeah, it knows about that too), and checks that
> the catalog version matches what pg_rewind was compiled with.

... which might or might not be the same one that libpgcommon was compiled
with, no? I don't think you're really protecting yourself against version
skew that way.

regards, tom lane