Re: Review: ECPG FETCH readahead

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Antonin Houska <antonin(dot)houska(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Boszormenyi Zoltan <zboszor(at)pr(dot)hu>, PG Hackers <pgsql-hackers(at)postgresql(dot)org>, Michael Meskes <meskes(at)postgresql(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Hans-Jürgen Schönig <hs(at)cybertec(dot)at>
Subject: Re: Review: ECPG FETCH readahead
Date: 2014-04-24 12:50:07
Message-ID: 20140424125007.GA6376@feivel.credativ.lan
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thanks an awful lot Antonin.

> Committer availability might well be the issue, but missing review
> probably too.

Yes, you're right. If my taks is mostly one last glance and a commit I will make time for that.

> Whether this review is enough to move the patch to "ready for committer"
> - I tend to let the next CFM decide. (I don't find it productive to
> ignite another round of discussion about kinds of reviews - already saw
> some.)

I saw some remarks in your review that Zoltan wants to address. Once I got the
updated version I'll have a look at it.

Zoltan, could you send a new version by end of day tomorrow? I'll be sitting on
a plane for a longer time again on Saturday. :)

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
Jabber: michael.meskes at gmail dot com
VfL Borussia! Força Barça! Go SF 49ers! Use Debian GNU/Linux, PostgreSQL

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-04-24 12:56:45 Re: slow startup due to LWLockAssign() spinlock
Previous Message Etsuro Fujita 2014-04-24 11:59:46 Minor improvement to fdwhandler.sgml