quiet inline configure check misses a step for clang

From: Andres Freund <andres(at)2ndquadrant(dot)com>
To: pgsql-hackers(at)postgresql(dot)org
Subject: quiet inline configure check misses a step for clang
Date: 2014-04-03 10:47:00
Message-ID: 20140403104700.GX3750@awork2.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

The current quiet inline test doesn't work for clang. As e.g. evidenced in
http://buildfarm.postgresql.org/cgi-bin/show_stage_log.pl?nm=gull&dt=2014-04-03%2007%3A49%3A26&stg=configure
configure thinks it's not quiet.

Which means that postgres compiled with a recent clang will be noticably
slower than it needs to be.

The reason for that is that clang is smart and warns about static inline
if they are declared locally in the .c file, but not if they are
declared in a #included file. That seems to be a reasonable
behaviour...

I think that needs to be fixed. We either can make the configure test
considerably more complex or simply drop the requirement for quiet
inline.

Comments?

Greetings,

Andres Freund

--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2014-04-03 10:58:21 Re: GSoC proposal - "make an unlogged table logged"
Previous Message Andres Freund 2014-04-03 10:44:51 Re: GSoC proposal - "make an unlogged table logged"