Re: Comment - uniqueness of relfilenode

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Antonin Houska <antonin(dot)houska(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Comment - uniqueness of relfilenode
Date: 2014-03-08 17:20:44
Message-ID: 20140308172044.GC4690@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, Mar 6, 2014 at 09:20:39PM -0500, Bruce Momjian wrote:
> On Thu, Mar 6, 2014 at 08:34:29AM +0100, Antonin Houska wrote:
> > >>> You're right. I missed the fact that Postgres (unlike another DBMS that
> > >>> I worked with) allows for tablespace to be shared across databases.
> > >>
> > >> I have update the C comment:
> > >>
> > >> < * Notice that relNode is only unique within a particular database.
> > >> ---
> > >> > * Notice that relNode is only unique within a particular tablespace.
> > >
> > > Yep. But the new text is no more correct than the old text. Did you
> > > read what I wrote upthread?
> >
> > Perhaps "... unique within a particular (tablespace, database)
> > combination." ?
>
> Oh, I thought people just wanted the text to be consistent with other
> mentions, rather than improving it. Attached is a patch which updates
> comments about the tablespace/database issue.

Applied.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Murtuza Mukadam 2014-03-08 18:56:28 Re: git-review: linking commits to review discussion in git
Previous Message Bruce Momjian 2014-03-08 17:16:12 Re: pg_ctl status with nonexistent data directory