| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Antonin Houska <antonin(dot)houska(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Comment - uniqueness of relfilenode |
| Date: | 2014-03-07 02:20:39 |
| Message-ID: | 20140307022039.GC11419@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thu, Mar 6, 2014 at 08:34:29AM +0100, Antonin Houska wrote:
> >>> You're right. I missed the fact that Postgres (unlike another DBMS that
> >>> I worked with) allows for tablespace to be shared across databases.
> >>
> >> I have update the C comment:
> >>
> >> < * Notice that relNode is only unique within a particular database.
> >> ---
> >> > * Notice that relNode is only unique within a particular tablespace.
> >
> > Yep. But the new text is no more correct than the old text. Did you
> > read what I wrote upthread?
>
> Perhaps "... unique within a particular (tablespace, database)
> combination." ?
Oh, I thought people just wanted the text to be consistent with other
mentions, rather than improving it. Attached is a patch which updates
comments about the tablespace/database issue.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| Attachment | Content-Type | Size |
|---|---|---|
| relfilenode.diff | text/x-diff | 2.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-03-07 02:25:11 | Re: pg_ctl status with nonexistent data directory |
| Previous Message | Josh Berkus | 2014-03-07 01:55:42 | Clustering and PostgresXC meetings at pgCon 2014 |