| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | YAMAMOTO Takashi <yamamoto(at)valinux(dot)co(dot)jp>, pgsql-bugs(at)postgresql(dot)org, rhaas(at)postgresql(dot)org |
| Subject: | Re: bug in ReplicationSlotsCountDBSlots |
| Date: | 2014-03-07 16:42:28 |
| Message-ID: | 20140307164228.GC21154@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Mar 7, 2014 at 05:22:03PM +0100, Andres Freund wrote:
> On 2014-03-07 11:18:04 -0500, Bruce Momjian wrote:
> > On Fri, Mar 7, 2014 at 11:43:21AM +0900, YAMAMOTO Takashi wrote:
> > > hi,
> > >
> > > the following fixes an obvious bug in ReplicationSlotsCountDBSlots
> > > which prevents dropping unrelated databases.
>
> Thanks, that's obviously a mistake!
>
> > Yikes, the code is literally:
> >
> > /* not database specific, skip */
> > if (s->data.database == InvalidOid)
> >
> > How did that get by the reviewers?
>
> It's a huge patch, and it changed a lot to accomodate review and to
> rebase onto new versions. I think I introduced that bug when rebasing
> the decoding functionality onto the already committed slot
> functionality. Since it doesn't cause any obvious problems in many
> scenarios..
>
> Can you push that fix?
Done, thanks.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2014-03-07 17:16:37 | Re: BUG #9472: pg_dumpall fails with "unrecognized node type: 650" |
| Previous Message | Andres Freund | 2014-03-07 16:22:03 | Re: bug in ReplicationSlotsCountDBSlots |