| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | YAMAMOTO Takashi <yamamoto(at)valinux(dot)co(dot)jp>, pgsql-bugs(at)postgresql(dot)org, rhaas(at)postgresql(dot)org |
| Subject: | Re: bug in ReplicationSlotsCountDBSlots |
| Date: | 2014-03-07 16:22:03 |
| Message-ID: | 20140307162203.GG22909@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 2014-03-07 11:18:04 -0500, Bruce Momjian wrote:
> On Fri, Mar 7, 2014 at 11:43:21AM +0900, YAMAMOTO Takashi wrote:
> > hi,
> >
> > the following fixes an obvious bug in ReplicationSlotsCountDBSlots
> > which prevents dropping unrelated databases.
Thanks, that's obviously a mistake!
> Yikes, the code is literally:
>
> /* not database specific, skip */
> if (s->data.database == InvalidOid)
>
> How did that get by the reviewers?
It's a huge patch, and it changed a lot to accomodate review and to
rebase onto new versions. I think I introduced that bug when rebasing
the decoding functionality onto the already committed slot
functionality. Since it doesn't cause any obvious problems in many
scenarios..
Can you push that fix?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2014-03-07 16:42:28 | Re: bug in ReplicationSlotsCountDBSlots |
| Previous Message | Bruce Momjian | 2014-03-07 16:18:04 | Re: bug in ReplicationSlotsCountDBSlots |