Re: A minor correction in comment in heaptuple.c

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, Kevin Grittner <kgrittn(at)ymail(dot)com>, "D'Arcy J(dot)M(dot) Cain" <darcy(at)druid(dot)net>, Amit Langote <amitlangote09(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A minor correction in comment in heaptuple.c
Date: 2014-01-28 17:29:25
Message-ID: 20140128172925.GL20898@momjian.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Jan 28, 2014 at 02:25:51PM -0300, Alvaro Herrera wrote:
> Bruce Momjian escribió:
> > On Tue, Jan 28, 2014 at 11:20:39AM -0500, Tom Lane wrote:
> > > Andres Freund <andres(at)2ndquadrant(dot)com> writes:
> > > > On 2014-01-28 11:14:49 -0500, Bruce Momjian wrote:
> > > >> OK, so does anyone object to removing this comment line?
> > >
> > > > Let's just not do anything. This is change for changes sake. Not
> > > > improving anything the slightest.
> > >
> > > Indeed. I'd actually request that you revert your previous change to the
> > > comment, as it didn't improve matters and is only likely to cause pain for
> > > future back-patching.
> >
> > OK, so we have a don't change anything and a revert. I am thinking the
> > new wording as a super-minor improvement. Anyone else want to vote?
>
> I vote to revert to the original and can we please wait for longer than
> a few hours on a weekend before applying this kind of change that is
> obviously not without controversy.

OK, reverted. I have to question how well-balanced we are when a word
change in a C comment can cause so much contention.

--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com

+ Everyone has their own god. +

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2014-01-28 17:30:40 Re: A minor correction in comment in heaptuple.c
Previous Message Christian Convey 2014-01-28 17:28:00 Re: alternative back-end block formats