| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | "Shiv Shivaraju Gowda (shivshi)" <shivshi(at)cisco(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, alvherre(at)2ndquadrant(dot)com |
| Subject: | Re: Re: PostgreSQL 6.2.5 Visual Studio Build does not pass the regression tests. |
| Date: | 2014-01-24 21:36:56 |
| Message-ID: | 20140124213656.GB2001840@tornado.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On Fri, Jan 24, 2014 at 10:14:24AM -0500, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > Would you verify that the attached patch fixes your builds?
>
> The aspect of this patch that leaves ImmediateInterruptOK set over a
> much larger code range in PGSemaphoreLock --- and in particular doesn't
> bother to reset it before entering ereport() --- is a horrid idea.
> Keep in mind that setting ImmediateInterruptOK means you can lose control
> *anywhere*, and so have no ability to safely manipulate anything except
> local variables.
What's wrong with ereport(FATAL) under ImmediateInterruptOK?
ClientAuthentication() does it, and errfinish() clears the flag.
--
Noah Misch
EnterpriseDB http://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| w32-io-completion-v2.patch | text/plain | 3.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | ERR ORR | 2014-01-24 21:44:26 | Postgresql 9.3.2 Server crashes upon start |
| Previous Message | John R Pierce | 2014-01-24 18:18:49 | Re: BUG #8956: fedora download does not contain pg_config |