Re: Re: PostgreSQL 6.2.5 Visual Studio Build does not pass the regression tests.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Noah Misch <noah(at)leadboat(dot)com>
Cc: "Shiv Shivaraju Gowda (shivshi)" <shivshi(at)cisco(dot)com>, "pgsql-bugs(at)postgresql(dot)org" <pgsql-bugs(at)postgresql(dot)org>, alvherre(at)2ndquadrant(dot)com
Subject: Re: Re: PostgreSQL 6.2.5 Visual Studio Build does not pass the regression tests.
Date: 2014-01-24 15:14:24
Message-ID: 12094.1390576464@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Noah Misch <noah(at)leadboat(dot)com> writes:
> Would you verify that the attached patch fixes your builds?

The aspect of this patch that leaves ImmediateInterruptOK set over a
much larger code range in PGSemaphoreLock --- and in particular doesn't
bother to reset it before entering ereport() --- is a horrid idea.
Keep in mind that setting ImmediateInterruptOK means you can lose control
*anywhere*, and so have no ability to safely manipulate anything except
local variables.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Bruce Momjian 2014-01-24 16:34:09 Re: BUG #8218: Error when querying an JSON data, 9.3beta
Previous Message Alvaro Herrera 2014-01-24 14:29:00 Re: BUG #8954: Wrong text in database log during "truncate scan"