Re: Patch - Re: [HACKERS] view vs. inheritance hierarchy

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Karel Zak - Zakkr <zakkr(at)zf(dot)jcu(dot)cz>
Cc: Jan Wieck <wieck(at)debis(dot)com>, pgsql-hackers <pgsql-hackers(at)postgreSQL(dot)org>
Subject: Re: Patch - Re: [HACKERS] view vs. inheritance hierarchy
Date: 1999-10-31 16:59:58
Message-ID: 20140.941389198@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Karel Zak - Zakkr <zakkr(at)zf(dot)jcu(dot)cz> writes:
> *** ruleutils.c.org Mon Sep 6 00:55:28 1999
> --- ruleutils.c Sun Sep 31 13:37:42 1999
> ***************
> *** 968,971 ****
> --- 968,973 ----
> strcat(buf, "\"");
> strcat(buf, rte->relname);
> + if (rte->inh)
> + strcat(buf, "*");
> strcat(buf, "\"");
> if (strcmp(rte->relname, rte->refname) != 0)
> ***************
> *** 973,976 ****
> --- 975,980 ----
> strcat(buf, " \"");
> strcat(buf, rte->refname);
> + if (rte->inh)
> + strcat(buf, "*");
> strcat(buf, "\"");
> }

> Add we (Jan or Tom) this code to PostgreSQL source main? (Pease).

That looks about like the right thing to do, but I wonder whether the
"*" doesn't need to go *outside* the quote marks around the table name?
Seems like it would be taken as a name character if inside...

regards, tom lane

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrij Korud 1999-10-31 19:34:23 Trigger aborted on error
Previous Message Karel Zak - Zakkr 1999-10-31 14:26:51 Patch - Re: [HACKERS] view vs. inheritance hierarchy