From: | Bruce Momjian <bruce(at)momjian(dot)us> |
---|---|
To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
Cc: | pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: clang's -Wmissing-variable-declarations shows some shoddy programming |
Date: | 2013-12-19 03:11:03 |
Message-ID: | 20131219031103.GC1690@momjian.us |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Sat, Dec 14, 2013 at 04:52:28PM +0100, Andres Freund wrote:
> Hi,
>
> Compiling postgres with said option in CFLAGS really gives an astounding
> number of warnings. Except some bison/flex generated ones, none of them
> looks acceptable to me.
> Most are just file local variables with a missing static and easy to
> fix. Several other are actually shared variables, where people simply
> haven't bothered to add the variable to a header. Some of them with
> comments declaring that fact, others adding longer comments, even others
> adding longer comments about that fact.
>
> I've attached the output of such a compilation run for those without
> clang.
Now that pg_upgrade has stabilized, I think it is time to centralize all
the pg_upgrade_support control variables in a single C include file that
can be used by the backend and by pg_upgrade_support. This will
eliminate the compiler warnings too.
The attached patch accomplishes this.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ Everyone has their own god. +
Attachment | Content-Type | Size |
---|---|---|
pg_upgrade.diff | text/x-diff | 5.9 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Craig Ringer | 2013-12-19 03:21:19 | Re: row security roadmap proposal |
Previous Message | Amit Kapila | 2013-12-19 03:08:41 | Re: ALTER SYSTEM SET command to change postgresql.conf parameters |