| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | clang's -Wmissing-variable-declarations shows some shoddy programming |
| Date: | 2013-12-14 15:52:28 |
| Message-ID: | 20131214155228.GC3368@awork2.anarazel.de |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
Compiling postgres with said option in CFLAGS really gives an astounding
number of warnings. Except some bison/flex generated ones, none of them
looks acceptable to me.
Most are just file local variables with a missing static and easy to
fix. Several other are actually shared variables, where people simply
haven't bothered to add the variable to a header. Some of them with
comments declaring that fact, others adding longer comments, even others
adding longer comments about that fact.
I've attached the output of such a compilation run for those without
clang.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| missing-variable-declarations.txt | text/plain | 22.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2013-12-14 16:27:53 | Useless "Replica Identity: NOTHING" noise from psql \d |
| Previous Message | Andres Freund | 2013-12-14 15:04:16 | Re: PoC: Partial sort |