From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
---|---|
To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: git diff --check whitespace checks, gitattributes |
Date: | 2013-11-06 04:17:06 |
Message-ID: | 20131106041706.GK5809@eldon.alvh.no-ip.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> This makes the entire tree git diff --check clean. After this, future
> patches can be inspected for whitespace errors with git diff --check,
> something that has been discussed on occasion.
+1 to this, and also +1 to Tom's suggestion of making it more strongly
enforced.
> One open question is whether psql output pasted into documentation, in
> particular .sgml files, should preserve the trailing whitespace that
> psql produces. This is currently done inconsistently.
I think pasting psql output verbatim isn't such a great idea anyway.
Maybe it's okay for certain specific examples, but in most cases I think
it'd be better to produce native SGML tables instead of <programoutput>
stuff. After all, it's the result set that's interesting, not the way
psql presents it.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2013-11-06 04:44:53 | Re: ERROR during end-of-xact/FATAL |
Previous Message | Tom Lane | 2013-11-06 03:31:14 | Re: git diff --check whitespace checks, gitattributes |