From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | git diff --check whitespace checks, gitattributes |
Date: | 2013-11-06 03:18:03 |
Message-ID: | 1383707883.10722.5.camel@vanquo.pezone.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Attached is a patch that
- Adds a .gitattributes file to configure appropriate whitespace checks
for git diff --check.
- Cleans up all whitespace errors found in this way in existing code.
Most of that is in files not covered by pgindent, some in new code since
the last pgindent.
This makes the entire tree git diff --check clean. After this, future
patches can be inspected for whitespace errors with git diff --check,
something that has been discussed on occasion.
One open question is whether psql output pasted into documentation, in
particular .sgml files, should preserve the trailing whitespace that
psql produces. This is currently done inconsistently.
My preference is to trim the trailing whitespace, because otherwise it's
impossible to check for trailing whitespace errors in other parts of
those files.
Attachment | Content-Type | Size |
---|---|---|
0001-Fix-whitespace-issues-found-by-git-diff-check-add-gi.patch | text/x-patch | 72.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2013-11-06 03:31:14 | Re: git diff --check whitespace checks, gitattributes |
Previous Message | Josh Berkus | 2013-11-06 01:02:58 | Re: List of "binary-compatible" data types |