| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: appendStringInfo vs appendStringInfoString |
| Date: | 2013-10-30 16:12:18 |
| Message-ID: | 20131030161218.GD5922@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund escribió:
> On 2013-10-30 10:52:05 -0300, Alvaro Herrera wrote:
> > Robert Haas escribió:
> > > On Wed, Oct 30, 2013 at 4:51 AM, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > > > I've attached a re-based version of this.
> > >
> > > I don't see any compelling reason not to commit this. Does anyone
> > > wish to object?
> >
> > I think a blanket substitution of places that currently have %s might
> > cause bugs, particularly if the string is user-supplied. It might be
> > right for many cases, but did you/someone review each such callsite?
> >
> > No objection to the other half, that substitute calls that don't have
> > %s.
>
> appendStringInfoString() doesn't expand format strings, so I am not sure
> what you're worried about?
Um. Blame my lack of decent breakfast this morning.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2013-10-30 16:26:25 | Re: How can I build OSSP UUID support on Windows to avoid duplicate UUIDs? |
| Previous Message | Jeff Janes | 2013-10-30 16:07:07 | Re: Fast insertion indexes: why no developments |