| From: | Andres Freund <andres(at)2ndquadrant(dot)com> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, David Rowley <dgrowleyml(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: appendStringInfo vs appendStringInfoString |
| Date: | 2013-10-30 14:20:56 |
| Message-ID: | 20131030142056.GC11429@awork2.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2013-10-30 10:52:05 -0300, Alvaro Herrera wrote:
> Robert Haas escribió:
> > On Wed, Oct 30, 2013 at 4:51 AM, David Rowley <dgrowleyml(at)gmail(dot)com> wrote:
> > > I've attached a re-based version of this.
> >
> > I don't see any compelling reason not to commit this. Does anyone
> > wish to object?
>
> I think a blanket substitution of places that currently have %s might
> cause bugs, particularly if the string is user-supplied. It might be
> right for many cases, but did you/someone review each such callsite?
>
> No objection to the other half, that substitute calls that don't have
> %s.
appendStringInfoString() doesn't expand format strings, so I am not sure
what you're worried about?
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Leonardo Francalanci | 2013-10-30 14:23:04 | Re: Fast insertion indexes: why no developments |
| Previous Message | Simon Riggs | 2013-10-30 13:53:24 | Re: Fast insertion indexes: why no developments |