| From: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: libpgport vs libpgcommon |
| Date: | 2013-10-18 19:00:49 |
| Message-ID: | 20131018190049.GA5313@eldon.alvh.no-ip.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut wrote:
> On 10/16/13 10:10 PM, Noah Misch wrote:
> > dirmod.c perhaps deserves a
> > split into libpgcommon parts (e.g. pgfnames()) and libpgport parts
> > (e.g. pgrename()).
>
> I have also come to this realization. I propose to move pgfnames to
> src/common/pgfnames.c.
Please have a look at my patch at
20130827215416(dot)GF4933(at)eldon(dot)alvh(dot)no-ip(dot)org particularly the checkdir.c
file. Perhaps we'd like to put both these routines (which are related
to directories) in a single file (directory.c?). In that case I would
suggest putting your new routine in that file, and we'd add the checkdir
stuff in there eventually.
I don't necessarily object to pgfnames.c in any case, if that's thought
to be cleaner.
--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2013-10-18 19:29:02 | Re: Turning recovery.conf into GUCs |
| Previous Message | Andres Freund | 2013-10-18 18:50:58 | Re: logical changeset generation v6.4 |