Re: Running pgindent

From: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Running pgindent
Date: 2013-05-29 21:56:32
Message-ID: 20130529215632.GB2548@eldon.alvh.no-ip.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian escribió:

> Done. This was the first run of the Perl-based pgindent script. There
> was a lot of code churn in this run as the paragraphs are slightly
> wider. Also, I saw some outdenting of long lines, rather than allowing
> them to go past 80 characters, but it seemed minimal. If others see
> problems, we can adjust the script and run it again.

It seems a bit troubling to me that the underlying indent binary seems
to have behaved slightly different. I think this will cause problems
down the road when we try to backpatch stuff that has been indented
differently on the older branches.

I wonder if it would be best to inflict pgindent with the new script upon
the old active branches as well, to avoid this problem. (It might cause
other problems, of course.)

--
Álvaro Herrera http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2013-05-29 22:21:30 Re: Running pgindent
Previous Message Bruce Momjian 2013-05-29 21:01:05 Re: Running pgindent