Re: [v9.3] Row-Level Security

On Mon, Dec 03, 2012 at 03:41:47PM +0000, Simon Riggs wrote:
> On 3 December 2012 15:36, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp> wrote:
> > 2012/12/3 David Fetter <david(at)fetter(dot)org>:
> >> On Sun, Nov 25, 2012 at 03:20:28PM +0100, Kohei KaiGai wrote:
> >>> > However, UPDATE / DELETE support is not perfect right now.
> >>> > In case when we try to update / delete a table with inherited
> >>> > children and RETURNING clause was added, is loses right
> >>> > references to the pseudo columns, even though it works fine
> >>> > without inherited children.
> >>> >
> >>> The attached patch fixed this known problem.
> >>
> >> This patch no longer applies to git master. Any chance of a rebase?
> >>
> > OK, I'll rebese it.
>
> No chunk failures, its just fuzz.

I must have done something wrong.

I downloaded the patch from the web email archives, then ran "git
apply" on it, and got this:

$ git apply ../pgsql-v9.3-row-level-security.rw.v7.patch
../pgsql-v9.3-row-level-security.rw.v7.patch:806: space before tab in indent.
* row-level security policy
../pgsql-v9.3-row-level-security.rw.v7.patch:1909: trailing whitespace.
* would be given. Because the sub-query has security barrier flag,
../pgsql-v9.3-row-level-security.rw.v7.patch:2886: trailing whitespace.
did | cid | dlevel | dauthor | dtitle
../pgsql-v9.3-row-level-security.rw.v7.patch:2899: trailing whitespace.
cid | did | dlevel | dauthor | dtitle | cname
../pgsql-v9.3-row-level-security.rw.v7.patch:2918: trailing whitespace.
did | cid | dlevel | dauthor | dtitle
error: patch failed: src/backend/commands/copy.c:34
error: src/backend/commands/copy.c: patch does not apply

What did I do wrong here?

Cheers,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778 AIM: dfetter666 Yahoo!: dfetter
Skype: davidfetter XMPP: david(dot)fetter(at)gmail(dot)com
iCal: webcal://www.tripit.com/feed/ical/people/david74/tripit.ics

Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate