| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
| Cc: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Support for XLogRecPtr in expand_fmt_string? |
| Date: | 2012-07-13 19:47:56 |
| Message-ID: | 20120713194756.GD15443@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jul 13, 2012 at 10:34:35PM +0300, Peter Eisentraut wrote:
> On tor, 2012-07-12 at 10:13 +0300, Heikki Linnakangas wrote:
> > One idea would be to use a macro, like this:
> >
> > #define XLOGRECPTR_FMT_ARGS(recptr) (uint32) ((recptr) >> 32),
> > (uint32)
> > (recptr)
> >
> > elog(LOG, "current WAL location is %X/%X",
> > XLOGRECPTR_FMT_ARGS(RecPtr));
> >
> I would rather get rid of this %X/%X notation. I know we have all grown
> to like it, but it's always been a workaround. We're now making the
> move to simplify this whole business by saying, the WAL location is an
> unsigned 64-bit number -- which everyone can understand -- but then why
> is it printed in some funny format?
+1
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2012-07-13 20:01:55 | Re: Support for XLogRecPtr in expand_fmt_string? |
| Previous Message | Peter Eisentraut | 2012-07-13 19:46:01 | Re: pgsql_fdw in contrib |