Re: Support for XLogRecPtr in expand_fmt_string?

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Support for XLogRecPtr in expand_fmt_string?
Date: 2012-07-13 19:34:35
Message-ID: 1342208075.23760.1.camel@vanquo.pezone.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On tor, 2012-07-12 at 10:13 +0300, Heikki Linnakangas wrote:
> One idea would be to use a macro, like this:
>
> #define XLOGRECPTR_FMT_ARGS(recptr) (uint32) ((recptr) >> 32),
> (uint32)
> (recptr)
>
> elog(LOG, "current WAL location is %X/%X",
> XLOGRECPTR_FMT_ARGS(RecPtr));
>
I would rather get rid of this %X/%X notation. I know we have all grown
to like it, but it's always been a workaround. We're now making the
move to simplify this whole business by saying, the WAL location is an
unsigned 64-bit number -- which everyone can understand -- but then why
is it printed in some funny format?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2012-07-13 19:36:13 Re: Schema version management
Previous Message Tom Lane 2012-07-13 19:21:27 Re: initdb and fsync