Re: Speed dblink using alternate libpq tuple storage

On Fri, Jan 27, 2012 at 09:35:04AM -0600, Merlin Moncure wrote:
> On Fri, Jan 27, 2012 at 2:57 AM, Kyotaro HORIGUCHI
> > - The meaning of PGresAttValue is changed. The field 'value' now
> >  contains a value withOUT terminating zero. This change seems to
> >  have no effect on any other portion within the whole source
> >  tree of postgresql from what I've seen.
>
> This is a minor point of concern. This function was exposed to
> support libpqtypes (which your stuff compliments very nicely by the
> way) and I quickly confirmed removal of the null terminator didn't
> cause any problems there. I doubt anyone else is inspecting the
> structure directly (also searched the archives and didn't find
> anything).
>
> This needs to be advertised very loudly in the docs -- I understand
> why this was done but it's a pretty big change in the way the api
> works.

Note that the non-NUL-terminated PGresAttValue is only used for row
handler. So no existing usage is affected.

But I agree using same struct in different situations is confusing,
thus the request for separate struct for row handler usage.

--
marko