| From: | Bruce Momjian <bruce(at)momjian(dot)us> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Jeremy Drake <pgsql(at)jdrake(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| Date: | 2011-09-04 04:30:43 |
| Message-ID: | 201109040430.p844Uho00500@momjian.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Bruce Momjian <bruce(at)momjian(dot)us> writes:
> > Tom Lane wrote:
> >> You seem to have entirely missed the point of Alvaro's remark, which is
> >> that you've got xlog.h including walsender.h (still) as well as
> >> walsender.h including xlog.h. That's broken.
>
> > Oh, OK, done. xlog.h removed from walsender.h and tested.
>
> I would have gone the other way on that one, if possible. Seems like
> xlog.h ought to be the lower-level file.
Agreed. Let me work on that.
--
Bruce Momjian <bruce(at)momjian(dot)us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ It's impossible for everything to be true. +
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-09-04 05:13:41 | pgsql: Clean up the #include mess a little. |
| Previous Message | Tom Lane | 2011-09-04 02:19:44 | pgsql: Remove unnecessary and circular #include. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-09-04 05:13:41 | pgsql: Clean up the #include mess a little. |
| Previous Message | Satoshi Nagayasu | 2011-09-04 03:56:15 | xlogdump 0.4.0 |