| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Jeremy Drake <pgsql(at)jdrake(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |
| Date: | 2011-09-04 01:48:38 |
| Message-ID: | 15585.1315100918@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> You seem to have entirely missed the point of Alvaro's remark, which is
>> that you've got xlog.h including walsender.h (still) as well as
>> walsender.h including xlog.h. That's broken.
> Oh, OK, done. xlog.h removed from walsender.h and tested.
I would have gone the other way on that one, if possible. Seems like
xlog.h ought to be the lower-level file.
Some quick mechanical analysis shows that's not the only circular
inclusion path in our headers, either: we have storage/proc.h including
replication/syncrep.h which includes storage/proc.h. That one appears
to be Simon's fault not yours though.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2011-09-04 02:19:44 | pgsql: Remove unnecessary and circular #include. |
| Previous Message | Bruce Momjian | 2011-09-04 01:25:40 | pgsql: walsender.h doesn't need xlog.h, per Tom. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Satoshi Nagayasu | 2011-09-04 03:56:15 | xlogdump 0.4.0 |
| Previous Message | Bruce Momjian | 2011-09-04 01:25:17 | Re: Re: [COMMITTERS] pgsql: Remove "fmgr.h" include in cube contrib --- caused crash on a Ge |